fix: values of local variables that are children of structs, arrays, bitfields or unions are set to invalid values when the setOffset() function of the parent is called.#174
Merged
Conversation
…bitfields or unions are set to invalid values when the setOffset() function of the parent is called. For example when a child of the Json built in data type is used as a reference argument to a function the values of the child and all its children become zero. For those four pattern types `setOffset()` changes the offsets of all the children and if the children are local the offset is set to the offset of the parent pattern which is clearly wrong. The fix consists on removing the code that changes the offsets of local variables in the four (five?) setOffset() functions. Also fixed unions using local variables to determine the pattern size.
lawm
pushed a commit
to lawm/PatternLanguage
that referenced
this pull request
Mar 13, 2026
…bitfields or unions are set to invalid values when the setOffset() function of the parent is called. (WerWolv#174) For example when a child of the Json built in data type is used as a reference argument to a function the values of the child and all its children become zero. For those four pattern types `setOffset()` changes the offsets of all the children and if the children are local the offset is set to the offset of the parent pattern which is clearly wrong. The fix consists on removing the code that changes the offsets of local variables in the four (five?) setOffset() functions. Also fixed unions using local variables to determine the pattern size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example when a child of the Json built in data type is used as a reference argument to a function the values of the child and all its children become zero.
For those four pattern types
setOffset()changes the offsets of all the children and if the children are local the offset is set to the offset of the parent pattern which leads to the incorrect values for the local variables when pattern is evaluated from then on.The fix consists on removing the code that changes the offsets of local variables in the four (five?) setOffset() functions.